Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update a reference to evmjs #5382

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

kanej
Copy link
Member

@kanej kanej commented Jun 12, 2024

Refer to EDR instead of evmjs as it is no longer used for hardhat node.

The preview page is here: https://hardhat-git-docs-update-reference-to-evmjs-nomic-foundation.vercel.app/hardhat-network/docs/overview

Copy link

vercel bot commented Jun 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 8:57am

Copy link

changeset-bot bot commented Jun 12, 2024

⚠️ No Changeset found

Latest commit: 941321d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jun 12, 2024
@kanej kanej requested a review from alcuadrado June 12, 2024 10:41
@kanej kanej added the no changeset needed This PR doesn't require a changeset label Jun 12, 2024
@@ -15,7 +15,7 @@ It runs as either an in-process or stand-alone daemon, servicing JSON-RPC and We

By default, it mines a block with each transaction that it receives, in order and with no delay.

It's backed by the `@ethereumjs/vm` EVM implementation, the same one used by ganache and Remix.
It's backed by [EDR](https://github.com/NomicFoundation/edr), a custom EVM implementation written in Rust and targeting performance.
Copy link
Contributor

@ChristopherDedominici ChristopherDedominici Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we underline the fact that this custom implementation is made by us, the Hardhat team, or is it already implicit?

Like "It's backed by EDR, our custom EVM...."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it more explicit that it is ours is a good call, we have settled on:

It’s backed by [EDR](https://github.com/NomicFoundation/edr), Nomic Foundation’s Ethereum development runtime implementation for building developer tools.

Refer to EDR instead of evmjs as it is no longer used for `hardhat
node`.
@kanej kanej force-pushed the docs/update-reference-to-evmjs branch from a94ff1d to 941321d Compare June 13, 2024 08:55
@kanej kanej merged commit 0edfd50 into main Jun 13, 2024
7 checks passed
@kanej kanej deleted the docs/update-reference-to-evmjs branch June 13, 2024 09:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants