-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update a reference to evmjs #5382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@@ -15,7 +15,7 @@ It runs as either an in-process or stand-alone daemon, servicing JSON-RPC and We | |||
|
|||
By default, it mines a block with each transaction that it receives, in order and with no delay. | |||
|
|||
It's backed by the `@ethereumjs/vm` EVM implementation, the same one used by ganache and Remix. | |||
It's backed by [EDR](https://github.com/NomicFoundation/edr), a custom EVM implementation written in Rust and targeting performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we underline the fact that this custom implementation is made by us, the Hardhat team, or is it already implicit?
Like "It's backed by EDR, our custom EVM...."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it more explicit that it is ours is a good call, we have settled on:
It’s backed by [EDR](https://github.com/NomicFoundation/edr), Nomic Foundation’s Ethereum development runtime implementation for building developer tools.
d1a9281
to
a94ff1d
Compare
Refer to EDR instead of evmjs as it is no longer used for `hardhat node`.
a94ff1d
to
941321d
Compare
Refer to EDR instead of evmjs as it is no longer used for
hardhat node
.The preview page is here: https://hardhat-git-docs-update-reference-to-evmjs-nomic-foundation.vercel.app/hardhat-network/docs/overview